Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default-run to boa removing need for --bin #837

Merged
merged 1 commit into from
Oct 11, 2020

Conversation

RageKnify
Copy link
Member

This PR makes it so cargo run runs the boa binary like it used to before boa_tester was introduced.
boa_tester can still be run with cargo run --bin boa_tester.

It changes the following:

-Sets the default run binary to boa

@codecov
Copy link

codecov bot commented Oct 10, 2020

Codecov Report

Merging #837 into master will increase coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #837      +/-   ##
==========================================
+ Coverage   59.23%   59.37%   +0.13%     
==========================================
  Files         157      157              
  Lines       10034    10036       +2     
==========================================
+ Hits         5944     5959      +15     
+ Misses       4090     4077      -13     
Impacted Files Coverage Δ
boa/src/syntax/lexer/cursor.rs 62.71% <0.00%> (+2.02%) ⬆️
boa/src/syntax/ast/node/mod.rs 49.58% <0.00%> (+6.61%) ⬆️
boa/src/syntax/ast/node/new/mod.rs 78.94% <0.00%> (+6.72%) ⬆️
boa/src/syntax/ast/node/identifier/mod.rs 85.71% <0.00%> (+14.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89d2907...a949853. Read the comment docs.

@RageKnify RageKnify added the cli Issues and PRs related to the Boa command line interface. label Oct 10, 2020
@Lan2u Lan2u self-requested a review October 11, 2020 08:14
@Lan2u Lan2u merged commit fc8e575 into boa-dev:master Oct 11, 2020
@RageKnify RageKnify deleted the fix/defualt_run branch October 11, 2020 11:52
@RageKnify RageKnify added this to the v0.11.0 milestone Jan 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli Issues and PRs related to the Boa command line interface.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants